Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jim Angel going to emeritus #7035

Merged
merged 2 commits into from
May 9, 2023
Merged

Jim Angel going to emeritus #7035

merged 2 commits into from
May 9, 2023

Conversation

jimangel
Copy link
Member

TL;DR: This PR removes myself as an approver/reviewer in SIG Docs.

Ref: kubernetes/website#38864

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2023
@jimangel jimangel mentioned this pull request Jan 10, 2023
Merged
@aojea
Copy link
Member

aojea commented Jan 10, 2023

😢

@MadhavJivrajani
Copy link
Contributor

Thank you for everything Jim! ♥️

sftim
sftim reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do hesitate to write anything except positive feedback here, but: it'd be nice to split the update to add sig-docs/offboarding.md into its own commit.

/lgtm
👋 - you'll be much missed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@divya-mohan0209
Copy link
Contributor

Thank you for everything, Jim :)

divya-mohan0209
divya-mohan0209 reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left an initial set of comments on the offboarding docs. However, I second Tim on separating it into an individual commit.

sig-docs/offboarding.md Outdated Show resolved Hide resolved
sig-docs/offboarding.md Outdated Show resolved Hide resolved
@cblecker
Copy link
Member

/approve
/hold

Approving for top level. Please remove hold once feedback is addressed or is deemed unnecessary, and this is ready for merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2023
@jberkus
Copy link
Contributor

jberkus commented Feb 11, 2023

All:

So ... what's going on with this PR?

@jimangel
Copy link
Member Author

So ... what's going on with this PR?

Apologies @jberkus, that's on me. I let it rot. Addressing feedback today for merging.

@divya-mohan0209
Copy link
Contributor

Hey @jimangel , sorry to bother you again! I am reaching out to see if the feedback could be addressed so that we can merge this one in ahead of the Annual report. Thank you, in advance!

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2023
@jimangel
Copy link
Member Author

jimangel commented May 8, 2023 •
edited
Loading

My sincerest apologies for how long this took to resolve. I hope today is the first step forward to a better response time from me 😅

  • I addressed merge conflicts from my old branch
  • @sftim I split the PR into 2 commits (one for the offboarding docs and one for emeritus).
  • @divya-mohan0209 and @a-mccarthy I removed the (optional) steps from the bullets and softened the language around 6 months served before looking at replacements.

I think it's good to merge now. The off-boarding doc isn't meant to be authoritative, but more of a "something is better than nothing." I think once #6952 is figured out, it can be updated or merged into something more "official."

Thanks all and sorry again for how long this took to address feedback - not a reputation I want to keep. I'll catch y'all around! Cheers!

@reylejano
Copy link
Member

Thank you @jimangel

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 21b3de0 into kubernetes:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-mccarthy a-mccarthy a-mccarthy left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@sftim sftim sftim left review comments

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jimangel @aojea @MadhavJivrajani @divya-mohan0209 @cblecker @k8s-ci-robot @jberkus @reylejano @a-mccarthy @sftim